Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Claude's sole finding is confirmed as a nonblocking test-organization nit; Codex reported no findings. Adjudication used code inspection; tests were not executed.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/commands/login/login.integration.test.ts:210 |
test-organization |
claude | The default-token-name test exercises loginCryptoLayer directly but is placed in the login command's integration suite. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
brings the
api,httpandauthmodules under the effect lint,along with
profile,debugand the rest ofprojectwhats introduced?
dohFetchruns as one effect, and the request signal still only cancels the DoH lookup, so responses and fetch errors come back as beforeidentity-stitchwritestelemetry.jsonthrough a schema codec andDateTimewith the same bytes, a raw int64schema_versionincluded--debugHTTP timestamp and the default login token name read the clock through Effect, and the branch resolvers move toEffect.fnwith the same span namesTestClockandit.effect, with new cases for the abort handling, the int64 token, the debug timestamp and the token nameref